detect: Use elf_aux_info instead of mrs on aarch64 FreeBSD #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
the
O-arm
taiki-e
force-pushed
the
aarch64-freebsd-auxv
branch
from
fc1f781
to
20a1ba0
Compare
Our (unreleased) current feature detection code and
`is_aarch64_feature_detected` (as of nightly-2023-01-23) always use
`mrs` on aarch64 FreeBSD. However, they do not work on FreeBSD 12 on
QEMU (confirmed on FreeBSD 12.{2,3,4}), and we got SIGILL (worked on
FreeBSD 13 and 14).
So use `elf_aux_info` instead of `mrs` like `compiler-rt` does.
https://man.freebsd.org/elf_aux_info(3)
https://reviews.llvm.org/D109330
taiki-e
force-pushed
the
aarch64-freebsd-auxv
branch
from
20a1ba0
to
5f68585
Compare
taiki-e
added
O-aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our (unreleased) current feature detection code and
is_aarch64_feature_detected(as of nightly-2023-01-23) always usemrson aarch64 FreeBSD. However, they do not work on FreeBSD 12 on QEMU (confirmed on FreeBSD 12.{2,3,4}), and we got SIGILL (worked on FreeBSD 13 and 14).So use
elf_aux_infoinstead ofmrslikecompiler-rtdoes.https://man.freebsd.org/elf_aux_info(3)
https://reviews.llvm.org/D109330